-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Details implemented #811
base: devel
Are you sure you want to change the base?
Conversation
can you provide me please all the data that can be made visible so I can design something that makes sense for the user? |
For the time being. I am just displaying the tx id and type of tx, INTERNAL or EXTERNAL |
@editwentyone, me and tbk have decided that this is some of the data that we want to display to user:
Please use this data to make a UI |
@0xSaksham sure, let me clarify first, if I understood correctly: the user open up the "schedule details" to find this information: in about this "time", the status is "scheduled or running", the funds will arrive into "Jar A" to this address "destination id: bc1…"? source: |
Yes, a small change is that funds will leave from "Jar A" to the address "destination id" in about this "time", the status is "scheduled or running", the funds will be withdrawn from "Jar A" to this address "destination id: bc1…"? |
here is my attempt for the scheduler details , let me know what you think guys @theborakompanioni @0xSaksham |
@theborakompanioni I think it raised some merge conflict to this. Please accept the incoming change to fix it locally. |
there is nothing to review yet right? |
Can you resolve the conflicts yourself? You can always rebase on |
Just duplicate |
@0xSaksham It seems you have an old |
@0xSaksham Converted to darft as this seems not finished and reviewable. Undraft whenever you feel it is ready for review! 🚀 |
src/components/Jam.tsx
Outdated
@@ -382,6 +399,9 @@ export default function Jam({ wallet }: JamProps) { | |||
> | |||
<div className="d-flex justify-content-center align-items-center">{t('scheduler.button_stop')}</div> | |||
</rb.Button> | |||
{currentSchedule.length === 2 || currentSchedule.length === 8 ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand why it is limited to schedules with certain amounts of entries. Care to elaborate? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, currently the scheduler only supports 3 destination addresses, hence currentSchedule.length === 8
and,
currentSchedule === 2
is for the dev mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The amount of schedule entries depends also on the distribution of funds in your jars
If you want to make it available exclusively in dev mode, please use isDevMode
.
Created a basic funtionality for the show details tab
Current Stage: