Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderBook added in footer #814

Merged
merged 9 commits into from
Aug 22, 2024

Conversation

SnehalSrivastava27
Copy link
Contributor

@SnehalSrivastava27 SnehalSrivastava27 commented Aug 17, 2024

Fixes #752.

@SnehalSrivastava27
Copy link
Contributor Author

@theborakompanioni pull request added to add orderbook into footer

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Aug 19, 2024

@theborakompanioni pull request added to add orderbook into footer

Nice, @SnehalSrivastava27! I'll take a look asap! Thank you 🙏

Ping @editwentyone - can you take a look whether this corresponds to your ideas?

@SnehalSrivastava27
Copy link
Contributor Author

@theborakompanioni can you please tell why the build error is occurring I am unable to get it

@theborakompanioni
Copy link
Collaborator

theborakompanioni commented Aug 20, 2024

@theborakompanioni can you please tell why the build error is occurring I am unable to get it

The linter is failing. Could you rebase your changes on the latest devel branch and run npm run format? I think there was an update of prettier.

Also, could you:

  • Make the new orderbook button the same styling as the "Cheatsheet"
  • Label it "Orderbook" instead of "Show orderbook"

📸

Something similar to this (maybe more padding between icon and label)..
What do you think?

Copy link
Contributor Author

@SnehalSrivastava27 SnehalSrivastava27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footer can display Orderbook

@SnehalSrivastava27
Copy link
Contributor Author

image

@theborakompanioni theborakompanioni changed the base branch from master to devel August 22, 2024 09:56
@theborakompanioni
Copy link
Collaborator

image

Made some small adaptions to align the styling of the nav links in the footer.
Thanks for your contribution @SnehalSrivastava27 ! Awesome : -)

@theborakompanioni theborakompanioni merged commit 830ce59 into joinmarket-webui:devel Aug 22, 2024
@SnehalSrivastava27
Copy link
Contributor Author

Thankyou so much for giving the chance to contribute

@theborakompanioni
Copy link
Collaborator

Thankyou so much for giving the chance to contribute

Open source projects always appreciate any and all contributions!
Using the software, asking questions and reporting bugs is extremely important.
Code contributions are one of the best things that can happen to a small team. Thank you! 🧡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drag Orderbook into Footer and/or Header
2 participants