Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README mentions urllib.parse.encode, but there's no encode in the urllib.parse module #220

Closed
ksze opened this issue Apr 9, 2019 · 4 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@ksze
Copy link

ksze commented Apr 9, 2019

Like the title says. I think you probably mean urllib.parse.urlencode for the query string parameters and urllib.parse.quote for other parts of the URL. Concrete examples of using those functions to construct URLs would also help immensely.

e.g. DATABASE_URL that includes:

  • addressing scheme
  • username
  • password
  • hostname or IP address
  • port
  • database name
  • connection options as query string parameters (PostgreSQL supports these)
@joke2k joke2k added the documentation Improvements or additions to documentation label Jul 12, 2019
@joke2k
Copy link
Owner

joke2k commented Jul 12, 2019

Hi @ksze

you're right, urllib package evolutions was a mess.
In the next release, I'll fix the readme.
Can you provide concrete examples to add to readme?

I think that to help people to encode an url I can link some tool like this one: https://www.urlencoder.org/

tkdchen pushed a commit to tkdchen/django-environ that referenced this issue Oct 6, 2019
@dureyingenieria
Copy link

@joke2k Do you mean an example like this one?

>>> import urllib.parse
>>> urllib.parse.quote("https://www.google.com/search?q=españa")
'https%3A//www.google.com/search%3Fq%3Despa%C3%B1a'

@jayvdb
Copy link

jayvdb commented Apr 19, 2022

#383 is for tips.rst ; after that, this issue is probably done.

@sergeyklay sergeyklay self-assigned this Jun 13, 2022
@sergeyklay sergeyklay added the bug Something isn't working label Jun 13, 2022
@sergeyklay
Copy link
Collaborator

Fixed in develop branch. Thank you for the report and for helping us make django-environ better. And I am sorry about the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants