-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-style file variable support (fixes #189) #328
Conversation
I'll take a look ASAP |
Oh, we're supporting 3.5 still. Easy changes to make for that. |
One design decision that should be considered: currently if you use a |
@SmileyChris Could you please update the PR descrption by adding a bit more info about purpose and possible use cases. |
@sergeyklay updated description, pushed py3.5 fix, 100% coverage, and hopefully fixed windows ci tests too |
050597c
to
480032b
Compare
Lint fixed (pfft, should use black's 88 line length now :D) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, everything looks quite good, except for a few nitpicking from me.
61987a4
to
50fa40e
Compare
Merged! Thank you for the patch, and for helping us make django-environ better. |
is there a timeline for the next release that includes this PR? |
I'll try to find time for release this weekend. |
Docker (swarm) and Kubernetes are two widely used platforms that store their Secrets in tmpfs inside containers as individual files.
These are a secure way to be able to share configuration data between containers, and having a way to access these in django-environ is useful.
Here's a quote from the official Postgres docker hub image: