-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle escaped dollar sign in values #333
Conversation
1a70e2f
to
1e4dadc
Compare
@sergeyklay ready for review. |
@mehdy Thank you for the patch. In fact, I'd like to go this way:
I'm trying to understand how much your patch might hinder or help with this plan. |
@sergeyklay You're welcome! I think I can add a feature flag to the escaping logic so it meets the first step's requirements. |
Yeah, it would be better. Also could you disable it by default? |
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
@sergeyklay What do you think of this? |
@mehdy Looks as I expected, thanks! Could you please add a quick note to the documentation? Feel free to edit the tips.rst to show possible use cases and examples. |
@sergeyklay Sure! |
@sergeyklay I think we're good to go! |
Signed-off-by: Mehdy Khoshnoody <mehdy.khoshnoody@gmail.com>
Thank you for the patch, and for helping make django-environ better! |
Fixes #271