Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for secure Elasticsearch connections #463

Merged
merged 3 commits into from
Apr 22, 2023

Conversation

mizi
Copy link
Contributor

@mizi mizi commented Apr 11, 2023

Added support for elasticsearchs, elasticsearch2s, elasticsearch5s and elasticsearch7s schemes.
Which will translate into https://server server URL instead of http://server.
This fix is required, since AWS OpenSearch Service now forces HTTPS in many cases.

@sergeyklay sergeyklay self-requested a review April 20, 2023 07:47
@sergeyklay sergeyklay added the enhancement New feature or request label Apr 20, 2023
@github-actions
Copy link

Coverage Status

Coverage: 91.45% (+0.08%) from 91.37% when pulling 44bb096 on mizi:develop into d1494c6 on joke2k:develop.

Copy link
Collaborator

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this Pull Request. Overall, the changes look good and align with the project's philosophy. However, before I can accept your Pull Request, I'd like to ask you to make the following adjustments:

Please make the necessary code style adjustments to ensure your code adheres to our project's style guide. This will help improve code readability and make it easier to maintain in the future.

It would be great if you could update the changelog to reflect your changes. This will make it easier for other developers to track the project's changes and expedite the review process.

Once you've made these adjustments, I'll be happy to accept your Pull Request. If you have any questions or need assistance, please don't hesitate to reach out.

Thank you for your contribution to the project!

environ/environ.py Outdated Show resolved Hide resolved
@sergeyklay sergeyklay merged commit 428c3cb into joke2k:develop Apr 22, 2023
@sergeyklay
Copy link
Collaborator

Thank you!

@sergeyklay sergeyklay self-assigned this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants