Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seed phrase text cut off on iOS #1299

Merged
merged 3 commits into from
May 9, 2019

Conversation

saifahn
Copy link

@saifahn saifahn commented May 8, 2019

CenteredText was causing some problems, potentially due to the width: '100%' declaration. The SeedPhrase component has been refactored to
not use Block or CenteredText.

saifahn added 2 commits May 8, 2019 12:47
CenteredText was causing some problems, potentially due to the `width:
'100%'` declaration. The SeedPhrase component has been refactored to
not use Block or CenteredText.
@chunningham chunningham self-requested a review May 8, 2019 12:51
Copy link
Contributor

@chunningham chunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, using the react native elements makes more sense, tried it with a few seed phrases on the smallest ios sim (5s) and didnt get any cutoff, nice

@saifahn saifahn merged commit b898197 into develop May 9, 2019
@saifahn saifahn deleted the fix-text-cut-off-seed-phrase-ios branch May 9, 2019 11:56
This was referenced May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants