Consolidate error handling

[mnzaki]

There's an AppError class and associated ErrorCode enum with constants for the kinds of application errors in lib/errors.ts. Usage tends to be new AppError(ErrorCode.SomeError, caughtErr). Each AppError has a related message, which it gets automatically based on type. It's a little annoying to import the class and enum and also refer to the error code like that, but it's the easiest way I could find so far. Any feedback on usage, error messages, and names of the class, enum, constants?

I tested only 2 of the error conditions (ParseJWTFailed and CredentialRequestFailed), probably needs more testing, perhaps as part of test cases for the sso actions.

The caughtError gets logged, but I also think we should introduce sentry which is coincidentally free for opensource

[chunningham]

I like how this is done, but there are still four occurrences of the old pattern in actions/account/index.ts

[mnzaki]

@chunningham ah missed that file, gonna convert it as well.

For the checkIdentityExists action, it's unclear what error it should throw on failure. What do you think?
I'm also thinking about removing the Failed prefix from all the enum keys :D seems redundant

[chunningham]

theres multiple issues that can cause an identity wallet failure, mostly its internet connectivity issues but yeah something vague like "Unable to authenticate identity" or something should work. removing Failed from the enum makes sense but it is descriptive and there's not real overhead imo

[mnzaki]

Another point is about the error code strings, because we might want to actually display these to the users, and maybe they will be reported or something

[chunningham]

nice