Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading screen with the logic of setting up an identity account #977

Merged
merged 40 commits into from
May 1, 2018

Conversation

katszwn
Copy link

@katszwn katszwn commented Apr 12, 2018

Description

TODO:

  • tests
  • create identity
  • IPFS
  • Ethereum integration

Fixes #966

What does it solve?
Added container for loading, set up middleware which injects Jolocom Lib in actions, hooked up generate keys functionality to the loading component.

Were there any particular challenges that you faced and/or things that were not straightforward?

CURRENT BLOCKERS:

  • IPFS library is not working, probably due to how it's making HTTP requests - it's probably incompatible with how React Native makes HTTP requests, which doesn't support streams, binary data by default. NEXT STEPS: try out different IPFS libraries, or make requests manually using react native HTTP API, perhaps use https://github.com/joltup/react-native-fetch-blob
  • there was an issue with ES6 syntax in the jolocom-lib. Turned out the library was transpiled in a wrong way, but that exposed another issue on iOS, which was previously (before re-transpiling and updating ReactNative) running past the identity creation - Use Object.defineProperties instead of Object.assign jolocom-lib#50, the WIP solution is pushed to the corresponding branch, JSON parsing is broken. Perhaps it's worth doing further research on the cause of this issue and the Android issue - perhaps we should also use ts-loader next to babel-loader

What should others know about the solution?
Backend Middleware should be used to inject agents and external libraries that needs initializing

Is this change going to break other dependent services?
No

Checklist

  • Keep flags added to the PR up to date
  • Make sure the title describes the code well, description should contain Fixes #number_of_an_issue and a brief decscription of changes
  • Make sure the PR is readable and contains changes only related to a single issue. Otherwise - divide into separate PRs
  • Add a screenshot if there were any UI changes involved
  • Add new tests and make sure all tests are passing
  • Make sure all edge cases are taken into account and covered by tests
  • Run linter and fix all the errors and warnings

@Exulansis
Copy link
Collaborator

This is ready for merging, there is one issue with Snyk, but I do not have the privileges to see it for some reason :D Once that is solved, we can proceed.

I will create a new branch for implementing a generic error screen, and then complete the error handling on this branch.

@Exulansis Exulansis self-assigned this May 1, 2018
@Exulansis Exulansis merged commit ea9cb8f into develop May 1, 2018
@Exulansis Exulansis deleted the feature/#966_loading_screen_setting_up_account branch May 1, 2018 14:27
clauxx added a commit that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading screen and setting up the account
2 participants