-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading screen with the logic of setting up an identity account #977
Merged
Exulansis
merged 40 commits into
develop
from
feature/#966_loading_screen_setting_up_account
May 1, 2018
Merged
Loading screen with the logic of setting up an identity account #977
Exulansis
merged 40 commits into
develop
from
feature/#966_loading_screen_setting_up_account
May 1, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g from the state in the container
…tive utility was overriding utf8 node package
This is ready for merging, there is one issue with Snyk, but I do not have the privileges to see it for some reason :D Once that is solved, we can proceed. I will create a new branch for implementing a generic error screen, and then complete the error handling on this branch. |
…e handled on a separate branch.
…en' into feature/#966_loading_screen_setting_up_account
This was referenced May 1, 2018
clauxx
added a commit
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO:
Fixes #966
What does it solve?
Added container for loading, set up middleware which injects Jolocom Lib in actions, hooked up generate keys functionality to the loading component.
Were there any particular challenges that you faced and/or things that were not straightforward?
utf8
packages react native in version 0.52 had a util for utf8 conversion and it was overriding npm package (utf8.decode() is not a function error mathiasbynens/utf8.js#17) - upgraded React Native to the latest version fixed the issueCURRENT BLOCKERS:
What should others know about the solution?
Backend Middleware should be used to inject agents and external libraries that needs initializing
Is this change going to break other dependent services?
No
Checklist
Fixes #number_of_an_issue
and a brief decscription of changes