improvement way to get root SDK versions #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just added a function which acts like a ternary with fallback option. Hence, less cluttered "def" variables additionally, changed the SDK values from 23 to 26 as per new changes from react-native and Android Android Target API Level 26 will be required in August 2018. https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html And the React Native team is already working on this: facebook/react-native#18095 facebook/react-native#17741 PS: I am aware of this PR joltup#128 but first its still targeting old SDK values i.e 23 as fallback and secondly I am not sure of the use of `project` to get the value instead of proper way i.e `rootProject.ext` to get the property value.
sarahcodez
suggested changes
Aug 4, 2018
android/build.gradle
Outdated
| @@ -33,7 +37,7 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile 'com.facebook.react:react-native:+' | |||
| compile 'com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}' | |||
| //compile 'com.squareup.okhttp3:okhttp:+' | |||
There was a problem hiding this comment.
@yeomann Thanks for this commit--it got me past the first hurdle adding rn-fetch-blob to a new project. Line 40 threw an exception during build though until I wrapped the string in double quotes. Could you apply a fix like that for the single quotes in single quotes issue?
(I haven't officially been added to this project yet, but I'm working with @Traviskn to merge this request as soon as possible.)
There was a problem hiding this comment.
oh balls! my bad, it was actually suppose to be wrapped with double quotes, I have tested this multiple times, single quotes within single quotes doesn't work. let me fix it.
yeomann
commented
Aug 4, 2018
|
Thanks! |
This was referenced Aug 6, 2018
cguino
pushed a commit
to BeApp/rn-fetch-blob
that referenced
this pull request
Jul 5, 2023
…e64-dependency added missing base64 dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just added a function which acts like a ternary with fallback option. Hence, less cluttered "def" variables
additionally, changed the SDK values from 23 to 26 as per new changes from react-native and Android
Android Target API Level 26 will be required in August 2018.
https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html
And the React Native team is already working on this:
facebook/react-native#18095
facebook/react-native#17741
PS: I am aware of this PR #128 but first its still targeting old SDK values i.e 23 as fallback and secondly I am not sure of the use of
projectto get the value instead of proper way i.erootProject.extto get the property value.