Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix progress and uploadProgress not callback in iOS #155

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

yurnery
Copy link

@yurnery yurnery commented Aug 20, 2018

Desc:

  1. in iOS, when create a task like this code , the progress will not callback
RNFetchBlob.config({
              path
            })
              .fetch('POST', url)
              .progress({ interval: 250 }, (received, total) => {
                console.log('=============wws😆😆😆: ', received, total);
              })
              .then(res => {
                console.log('=============wws😆😆😆: ', res);
              });
  1. I check the iOS native code, the enableProgressReport method called before sendRequest, then the code [self.requestsTable objectForKey:taskId] got nil, so the request's config will not set, the progress notification will never send
  2. i fix it, if you have interest, check the commit
  3. it allow fix the progress dose no work in iOS becausesetProgress will call before sendRequest #96

@lefoy
Copy link

lefoy commented Aug 21, 2018

@Traviskn please merge we need this 🙏

@Traviskn
Copy link

Thanks for your PR!

@Traviskn Traviskn merged commit ebbf54e into joltup:master Aug 21, 2018
@saibayadon
Copy link

Any idea when this is going to hit NPM?

@Traviskn
Copy link

We still need to do some manual testing of recent changes and then we can publish to NPM

@kaddyadriano
Copy link

kaddyadriano commented Dec 22, 2018

I'm still having this issue on android. I'm using v.0.10.14 of the package. progress is not being called when I add config method in the mix. This works RNFetchBlob.fetch().progress() but this RNFetchBlob.config(options).fetch().progress() does not work. Is there any solution?

cguino pushed a commit to BeApp/rn-fetch-blob that referenced this pull request Jul 5, 2023
…ss-by-id

Filter progress reports from DownloadManager by id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants