Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes [joltup/rn-fetch-blob#225] #226

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Conversation

mgeier63
Copy link

Fixes [#225]

@rajivshah3
Copy link

@mgeier63 should master be the target branch for this PR?

@mgeier63
Copy link
Author

mgeier63 commented Nov 3, 2018

@rajivshah3 according to these instructions https://github.com/joltup/rn-fetch-blob-dev/blob/master/README.md the current "bug fix branch" is v0.10.9 - so I chose that one as the target branch.

@rajivshah3
Copy link

Oh whoops, didn't see that. Don't mind me then 😄

@Traviskn
Copy link

sorry https://github.com/joltup/rn-fetch-blob-dev/blob/master/README.md has not been updated, we are no longer using the v0.10.9 - all PRs from now on should be opened against the master branch

@demarchisd
Copy link

any idea when this will be merged into master?

@jaison-x
Copy link

Any prevision to merge with master?

@jsamr
Copy link

jsamr commented Mar 9, 2019

Please merge ; I've just faced this issue today.

@mo-patel
Copy link

Any clue when this will be merged?

@Traviskn
Copy link

thanks for this PR, apologies for the delayed review

@Traviskn Traviskn merged commit 92e9a63 into joltup:0.10.9 Sep 26, 2019
@tmaly1980
Copy link

@Traviskn Why is this going into 0.10.9? And not master?

@Traviskn
Copy link

Oh I didn't realize that this PR wasn't opened against the master branch 🤦‍♂

@tmaly1980
Copy link

@Traviskn So what needs to happen for this bugfix to go out? This is breaking all my Android O/P apps.

@tmaly1980
Copy link

@Traviskn Looks like this is already on master:

95207a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants