Fixing #236 which did not expect null from DownloadManager.query() #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimon70007
reviewed
May 23, 2019
|
Code was deployed in a live application. I tried to update the test cases and run those, but it seemed like a longer effort and had to abandon it. |
|
Oh. There is no tests in this library. |
|
oh no. #236 - is because of downloading large files. this fix did not helped me. |
uraniumreza
approved these changes
Jun 19, 2019
|
If this is working in a live application I am comfortable with merging, thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: I wasn't able to find contribution guidelines for PRs, so PR is against master as the issue-236 branch is quite stale.
This is a proposed fix to issue #236 which was due to a missing null check in onReceive() where DownloadManager.query() can return null, resulting in NullPointerException in some rare cases.