Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel download throw error bugfix (Android) #381

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

CapitanRedBeard
Copy link

This PR is based on #363
In which @minextu wrote:

Moved from wkh237#568
Fixes #182

Original Description:

Issue wkh237#555 describes that aborting a download does not lead to promise rejection. This bug has been fixed so that both at Android and iOS the promise will be rejected.

Basically he found a working PR that was put up against the old wkh237 repo but was obviously out of date.

PR #363 has a couple of unnecessary commits attached to it so I've simply took the only commit that actually fixes the problem and made a new PR with that.

Tested this against iOS and Android and now both platform are throwing a catchable Error whenever you call .cancel() on fetch request as the documentation says it should

@Traviskn Can you review/merge this in when you get a chance, pretty harmless PR that fixes an old problem.

For anyone needing this functionality point to this repo/branch:

"rn-fetch-blob": "git+https://github.com/repodio/rn-fetch-blob.git#throw-on-cancel-android"

until this PR has been merged

@Traviskn
Copy link

Thank you for your PR, apologies for the delayed review

@Traviskn Traviskn merged commit 104a94e into joltup:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants