-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert to new react native config format #408
Conversation
according to the react-native cli docs: |
@Traviskn Just add required permission in docs. No need to autolink permission. A proper docs would be enough. |
@IntelliJAbhishek Hello, can we merge this PR? |
@oleksandr-dziuban maintainers of this repo can merge this PR. |
+1 Same here. Please merge this PR. |
+1 please check this PR & merge :) thanks |
2 similar comments
+1 please check this PR & merge :) thanks |
+1 please check this PR & merge :) thanks |
Waiting for this merge ! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the react-native.config.js script at all.
The script installs permissions, but these are already mentioned in the readme
When this merge will be in master? |
When someone merges the PR? |
@Traviskn Hello, is it possible to merge this PR? Or this library is not maintained anymore? |
We need it anyway to mograte to latest react-native standards, so could you please merge it? |
merging for now, planning on a follow up PR to update the README and remove the hook entirely |
No description provided.