Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Ios upload image should delete charset=utf-8 in http request header content-type ,otherwise will cause bug #76

Closed
wants to merge 8 commits into from

Conversation

Tim-Burbank
Copy link

Thank you for making a pull request ! Just a gentle reminder :)

  1. If the PR is offering a feature please make the request to our "Feature Branch" 0.11.0
  2. Bug fix request to "Bug Fix Branch" 0.10.9
  3. Correct README.md can directly to master

guimeira and others added 8 commits May 30, 2018 14:11
Update README with proper status code handling
Bug Fix: getExternalFilesDir null check
There are a million issues around people having issues with automatically linking and having a link to manual instructions would address a lot of these up front. This also follows the instructions pattern of most react native modules.
Add manual linking instructions
@Tim-Burbank
Copy link
Author

fix ios upload bugs

@Tim-Burbank
Copy link
Author

fix ios upload image bug

@Traviskn
Copy link

Can you describe more about the bug that is caused by charset=utf-8 in the request header? How can we reproduce the bug? We have been uploading files from iOS without problems for some time.

@Tim-Burbank
Copy link
Author

When i upload image to aliyun oss use 'Content-Type': 'multipart/form-data' , will cause a bug , they are not accept this header when upload image

@okb1100
Copy link

okb1100 commented Aug 13, 2018

We also have the same problem.
Our server returns a response with status code 403 when Content-Type has charset=utf-8 along with multipart/form-data, no problems with Android since charset=utf-8 is appended only on iOS.
Also the error is not limited to image files, we are trying to upload text/plain files. Appending charset=utf-8 to Content-Type only on iOS is inconsistent and should be removed.

react-native version: 0.56
rn-fetch-blob version: 0.10.12

@mokai
Copy link

mokai commented May 3, 2019

Similarly, because charset=utf-8 is added, 405 Status is returned when uploading images to Alibaba Cloud OSS.

react-native version: 0.59.5
rn-fetch-blob version: 0.10.15

@Traviskn
Copy link

charset=urf-8 has been removed by #310

@Traviskn Traviskn closed this Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants