Use id column for commit id only #1056
Conversation
koutcher
force-pushed
the
gh-1025-id-column
branch
2 times, most recently
from
6db4fb6
to
710f905
Compare
koutcher
changed the title
koutcher
force-pushed
the
gh-1025-id-column
branch
2 times, most recently
from
8373b8b
to
e3d4629
Compare
|
I wonder if it makes sense to color-code the commit ids like in the blame view, so it's even easier to spot identical refereences. Probably a bit too noisy though, since most references are different. |
|
From the test suite point of view, this PR doesn't break anything... @jonas, I tried to track the origin of this behaviour (i.e. using the id column to display reflog) and went as far as e32cad8 but I can't figure out why it was introduced. Maybe you can remember. It looks it was related to the stash view. Was it a way to show the stash reference when it was not displayed in the title window ? |
We just need a small change in tigrc: Edit: with only 14 colours in the palette, there are too many collisions and enabling this would trigger too many complaints that successive entries have the same colour. |
koutcher
force-pushed
the
gh-1025-id-column
branch
3 times, most recently
from
93e557c
to
749b415
Compare
|
Yes, the ID colouring was mainly for the blame view and as you say very limited and confusing to use it outside for other views due to collisions. It might make sense to be able to set a specific colour where |
Yes, from what I remember, the idea was to show the |
| if (state->reflogs) { | ||
| assert(state->reflogs >= line->lineno); | ||
| string_ncopy(view->ref, state->reflog[line->lineno - 1], | ||
| strlen(state->reflog[line->lineno - 1])); |
There was a problem hiding this comment.
👍 This will show the reflog ID in the title bar.
That way, you can better figure out identical references when browsing the reflog view. Show the reflog name in the title window instead. In the stash view, the id column also shows the commit id instead of the reference. Closes jonas#1025
|
Thanks @jonas. |
koutcher
changed the title
koutcher
force-pushed
the
gh-1025-id-column
branch
from
749b415
to
d50c7c1
Compare
That way, you can better figure out identical references when browsing
the reflog view. Show the reflog name in the title window instead. In
the stash view, the id column also shows the commit id instead of the
reference.
Closes #1025