-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about minimum serde version #651
Comments
Version 1.0.49 is already 5 years old. I am not sure any version of serde_with ever supported that. serde does add new API surfaces occasionally, and that is used. Supporting 1.0.49 is not possible. The last bump was to force serde to use syn v2. But this PR #588 bumps the dependency to fix the minimal version specified, and that requires 1.0.139. So my best guess is anything under 1.0.139 cannot be supported right now, but it might be higher. |
Oh my I'm sorry, I meant 1.0.149, my mistake. Let me update the original post. I see that the version you're at is indeed to pick up syn 2.x.x, so I'd understand if you can't go lower than that. But if 1.0.149 (update: 1.0.152 works actually too) is actually possible as the minimum without requiring any changes to the code here that'd be really really great. |
I can test this btw, this week I'll try pinning the version to 1.0.149 to see if it builds. |
PR to decrease the version: #653. Everything seems to pass. |
653: Decrease minimum serde version to 1.0.152 r=jonasbb a=banool As far as I can tell, the minimum version of 1.0.157 is unnecessary. The way I've determined that is just from running the build + tests: ``` cargo build --workspace cargo test --workspace ``` This addresses #651. For my needs at least 1.0.152 is actually sufficient (rather than 1.0.149), though we could try go lower. Co-authored-by: Daniel Porteous <daniel@dport.me>
PR is merged |
Could you release a new version of the crate so this change gets picked up? |
Hey hey!
I see that currently
serde_with
requires a minimum serde version of1.0.157
. I wonder if any earlier version would work or if there is some feature you need from that version onward?I ask because I have a codebase which is unfortunately stuck on
1.0.149
and I want to use a crate that depends onserde_with
.Thanks!
The text was updated successfully, but these errors were encountered: