Simplify serde_as handling around Options
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…store support for missing fields A `with` or `deserialize_with` on an `Option` field removes the ability to allow missing fields. This modification detects if the field is `Option` and the transformation is `Option<T>`. In this case it is likely that the missing field behavior is desired. A `no_default` can be added to supress this new behavior. This commit does not include any documentation changes. Closes #185
Document when `serde_as` will add `#[serde(default)]` on a field.
|
bors r+ |
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
- Coverage 71.34% 71.28% -0.06%
==========================================
Files 52 52
Lines 3720 3761 +41
==========================================
+ Hits 2654 2681 +27
- Misses 1066 1080 +14
Continue to review full report at Codecov.
|
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
#[serde_as]on a field of typeOptionchanges the behavior, in that the field can no longer be missing.This often times was unexpected and lead to confusion (e.g., #183, #185, #311, #417).
Now if both the field and the transformation type are
Optionthe#[serde(default)]attribute is added.Options are identified by exact text matches and these variants are supported:Optionstd::option::Option, with or without leading::core::option::Option, with or without leading::If a
defaultattribute already exists nothing happens. This new behavior can be suppressed by using#[serde_as(no_default)]on the field. If the transformation type is notOption, e.g., likeNoneAsEmptyString, nothing happens either.Closes #185