Implement JsonSchemaAs
for PickFirst
#721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second-to-last type that I've got an implementation queued up for. The only one left after this is
Seq
.This one is pretty straightforward: we put the involved schemas in an
anyOf
subschema. All the schemas except the first are annotated withwriteOnly: true
to indicate that they are only accepted when deserializing and not emitted when serializing. The one extra detail is that I've used an internalallOf
in each element so that settingwriteOnly: true
works even if the schema of the type is a reference to an external schema.I have also included tests and a snapshot test to show that everything works.