Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NaiveDatetime as parsing module for date-time format #68

Merged
merged 5 commits into from
Nov 11, 2021

Conversation

mrnovalles
Copy link
Contributor

Ever since #64 was merged, when using NaiveDateTime for dates, JSON validations started failing.
This commit allows for NaiveDateTime strings to be accepted as date-time ex_json schema formats.

@coveralls
Copy link

coveralls commented Nov 10, 2021

Coverage Status

Coverage remained the same at 94.925% when pulling 3e263aa on mrnovalles:format-naive-date-time into a71ad59 on jonasschmidt:master.

Co-authored-by: Jonas Schmidt <jonas.schmidt@wooga.net>
Co-authored-by: Jonas Schmidt <jonas.schmidt@wooga.net>
Copy link
Owner

@jonasschmidt jonasschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loos good. I will merge and release this 👍

@jonasschmidt jonasschmidt merged commit a1191fc into jonasschmidt:master Nov 11, 2021
@mrnovalles mrnovalles deleted the format-naive-date-time branch November 11, 2021 10:25
@jonasschmidt
Copy link
Owner

Published as https://hex.pm/packages/ex_json_schema/0.9.1 🚀 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants