Skip to content

Commit

Permalink
Only check that the event ids are the same in arrays (elastic#72624)
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathan-buttner committed Jul 21, 2020
1 parent 8c55e48 commit 5fb6fdc
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions x-pack/test/api_integration/apis/endpoint/resolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ import {
ResolverNodeStats,
ResolverRelatedAlerts,
} from '../../../../plugins/security_solution/common/endpoint/types';
import { parentEntityId } from '../../../../plugins/security_solution/common/endpoint/models/event';
import {
parentEntityId,
eventId,
} from '../../../../plugins/security_solution/common/endpoint/models/event';
import { FtrProviderContext } from '../../ftr_provider_context';
import {
Event,
Expand Down Expand Up @@ -167,10 +170,14 @@ const compareArrays = (
if (lengthCheck) {
expect(expected.length).to.eql(toTest.length);
}

toTest.forEach((toTestEvent) => {
expect(
expected.find((arrEvent) => {
return JSON.stringify(arrEvent) === JSON.stringify(toTestEvent);
// we're only checking that the event ids are the same here. The reason we can't check the entire document
// is because ingest pipelines are used to add fields to the document when it is received by elasticsearch,
// therefore it will not be the same as the document created by the generator
return eventId(toTestEvent) === eventId(arrEvent);
})
).to.be.ok();
});
Expand Down

0 comments on commit 5fb6fdc

Please sign in to comment.