Dynamic SVG changes #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing of the 'xlink:href' attribute is watched trough the MutationObserver if present or with the polling fallback.
Lowered polling time to 1s
|
What you could do instead is hijack the setAttribute method, right? |
|
Yes, it's a good idea! But is safe to change a methods? |
| this.cb_fn = cb_fn; | ||
| this.observed = []; | ||
|
|
||
| setInterval( this.checkAttributes.bind(this), 1000 ); |
There was a problem hiding this comment.
In IE8 you would need a Function.bind polyfill.
jonathantneal
force-pushed
the
master
branch
3 times, most recently
from
5a3614c
to
7d747cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have made a version with the possibility to change dynamically the 'xlink:href' attribute
What do you think?
Regards,
Andrea