Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website - XP build works under ReactOS #4623

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Torinde
Copy link
Contributor

@Torinde Torinde commented Nov 21, 2023

@maron2000
Copy link
Contributor

It's ok to test and report that it works on ReactOS, but I oppose to mention that it is as if it is officially supported.

@joncampbell123
Copy link
Owner

joncampbell123 commented Nov 22, 2023

It's ok to test and report that it works on ReactOS, but I oppose to mention that it is as if it is officially supported.

You could list it as supported, but experimental, with no warranty, etc.

Make a decision and I'll merge the pull request.

@maron2000
Copy link
Contributor

Thanks. I'll leave the decisions to @Torinde and @joncampbell123 .
Sorry for bothering.

Torinde added a commit to Torinde/dosbox-x that referenced this pull request Nov 23, 2023
@Torinde
Copy link
Contributor Author

Torinde commented Nov 23, 2023

OK, maybe a compromise would be to mention ReactOS as experimental/unofficial on the XP line of INSTALL.md? ReactOS users probably are savvy enough to try themselves the XP version and/or to read the Install instructions.

I made another PR for INSTALL.md, so @joncampbell123 can choose whether to merge this PR, the other PR or both.

We can also add a tooltil with "abbr" stating "Experimental support" on the website front page - should I try making such PR?

@joncampbell123 joncampbell123 merged commit 46346fa into joncampbell123:gh-pages Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants