Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider function key display in MORE command (PC-98) #4666

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

maron2000
Copy link
Contributor

MORE command on PC-98 didn't consider whether the Function key is displayed on the bottom of the display, so the command assumed all rows are available which is not always the case.
This PR adjusts the number of lines to display at a time considering whether the Function keys are displayed.

Fixes #4664.

25 lines with function key display
more_25lines_fn

25 lines, no function key display
more_25lines

20 lines mode
more_20lines_fn

@joncampbell123 joncampbell123 merged commit bb1986c into joncampbell123:master Dec 12, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The more command seem to be hardcoded to 25 screen lines, but the PC-98 has 24 useful lines+1 reserved line
2 participants