Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to quickcheck 1.0 #10

Closed
wants to merge 1 commit into from
Closed

Bump to quickcheck 1.0 #10

wants to merge 1 commit into from

Conversation

d2weber
Copy link

@d2weber d2weber commented Aug 17, 2023

This PR updates quickcheck. The difference to #9 is, that it fixes the capacity property test with_cap by discarding large sizes.

@jonhoo
Copy link
Owner

jonhoo commented Aug 25, 2023

Thanks, but I think I prefer the u8 approach. Discarding quickcheck runs in this way is usually not ideal, because it means that quickcheck spends loads of time generating test cases that then are just thrown away.

@jonhoo jonhoo closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d2weber @jonhoo