Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6 with newer hashbrown and no mod raw #22

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Release 0.6 with newer hashbrown and no mod raw #22

merged 1 commit into from
Oct 19, 2024

Conversation

jonhoo
Copy link
Owner

@jonhoo jonhoo commented Oct 19, 2024

Fixes #21 so crate will work on Rust 1.82.

We can't upgrade to hashbrown 0.15 since it removes the raw table support. This is known upstream, and may just be something we have to live with:

rust-lang/hashbrown#545 (comment)

To align with hashbrown, and given this is a breaking change regardless, we remove the raw module just like hashbrown has. This should hopefully increase the chances that one day we can move to hashbrown's new lower-level interface (HashTable) without a breaking change.

This release also removes the nightly feature because it was mostly useless.

@jonhoo jonhoo force-pushed the update branch 3 times, most recently from 1da2130 to caa3108 Compare October 19, 2024 08:55
Fixes #21 so crate will work on Rust 1.82.

We can't upgrade to `hashbrown 0.15` since it removes the `raw` table
support. This is known upstream, and may just be something we have to
live with:

  rust-lang/hashbrown#545 (comment)

To align with `hashbrown`, and given this is a breaking change
regardless, we remove the `raw` module just like `hashbrown` has. This
should hopefully increase the chances that one day we can move to
`hashbrown`'s new lower-level interface (`HashTable`) without a breaking
change.

This release also removes the `nightly` feature because it was mostly
useless.
@jonhoo jonhoo merged commit 404ca4e into main Oct 19, 2024
19 checks passed
@jonhoo jonhoo deleted the update branch October 19, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests will fail in 1.82 due to an old soundness hole in hashbrown
1 participant