Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to set font in flamegraphs to default fonts #244

Closed
itamarst opened this issue May 31, 2022 · 1 comment · Fixed by #252
Closed

Not possible to set font in flamegraphs to default fonts #244

itamarst opened this issue May 31, 2022 · 1 comment · Fixed by #252

Comments

@itamarst
Copy link
Contributor

In CSS I can do:

body {
     font-family: monospace;
}

but I can't do that with flamegraph, because it turns it into:

body {
     font-family: "monospace";
}

which means "the font called monospace" rather than "default monospace font".

@jonhoo
Copy link
Owner

jonhoo commented Jun 4, 2022

Ah, yes, that happens here:

enquote('\"', &opt.font_type),

I think we just need to teach that code path about the "special" font names so that it doesn't escape those! I'd be happy to take a look at a PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants