Don't quote generic font families in CSS #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing a font type to use for the generated flamegraph, if it is one of the following we shouldn't put quotes around it: * cursive * fantasy * monospace * serif * sans-serif
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
- Coverage 87.32% 87.30% -0.03%
==========================================
Files 18 18
Lines 2525 2528 +3
==========================================
+ Hits 2205 2207 +2
- Misses 320 321 +1
Continue to review full report at Codecov.
|
jonhoo
requested changes
Jun 22, 2022
|
Released in 0.11.6 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
When passing a font type to use for the generated flamegraph,
if it is one of the following we shouldn't put quotes around it: