Increase default flamegraph fidelity #204
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #153. PR #136 changed the semantics of the
--minwidth
option from output pixel width to percentage width (which is effectively the same as pct of total samples), which greatly reduced the default fidelity of flamegraphs as 0.1% of total time is quite coarse, especially once you start zooming in.This PR reduces the default to 0.01%, which produces pretty much identical output as flamegraph.pl / old inferno at ~1200px wide and includes a much greater number of bars. I think this change is worth making as it makes it reduces friction for people migrating from flamegraph.pl, and in my tests produces much more useful output by default.
I've also updated the description of the option to match the current behaviour, as it still mentioned pixels and that had me confused for a good while.