-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frame stroke option #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! I left a few comments.
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 87.30% 87.36% +0.06%
==========================================
Files 18 18
Lines 2528 2541 +13
==========================================
+ Hits 2207 2220 +13
Misses 321 321
Continue to review full report at Codecov.
|
This was proposed by `@nagisa` in jonhoo#248. The new option will be `--stroke-color` and default to `none` and accept any color. It use a non-configurable stroke width of 1. Fixes jonhoo#248
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Released in 0.11.7 🎉 |
This was proposed by
@nagisa
in #248.The new option will be
--stroke-color
and default tonone
and accept any color.It use a non-configurable stroke width of 1.
Fixes #248