Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frame stroke option #255

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Add frame stroke option #255

merged 2 commits into from
Jul 26, 2022

Conversation

Urgau
Copy link
Contributor

@Urgau Urgau commented Jul 17, 2022

This was proposed by @nagisa in #248.

The new option will be --stroke-color and default to none and accept any color.
It use a non-configurable stroke width of 1.

Fixes #248

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! I left a few comments.

src/flamegraph/mod.rs Outdated Show resolved Hide resolved
src/bin/flamegraph.rs Outdated Show resolved Hide resolved
src/bin/flamegraph.rs Show resolved Hide resolved
src/flamegraph/mod.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #255 (29a9d8a) into master (c9c07d2) will increase coverage by 0.06%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   87.30%   87.36%   +0.06%     
==========================================
  Files          18       18              
  Lines        2528     2541      +13     
==========================================
+ Hits         2207     2220      +13     
  Misses        321      321              
Impacted Files Coverage Δ
src/flamegraph/svg.rs 76.33% <50.00%> (+0.42%) ⬆️
src/flamegraph/color/mod.rs 83.64% <100.00%> (+0.64%) ⬆️
src/flamegraph/mod.rs 87.20% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c07d2...29a9d8a. Read the comment docs.

Urgau added 2 commits July 18, 2022 10:45
This was proposed by `@nagisa` in
jonhoo#248.

The new option will be `--stroke-color` and default to `none`
and accept any color. It use a non-configurable stroke width of 1.

Fixes jonhoo#248
Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@jonhoo jonhoo merged commit 2f74fe5 into jonhoo:master Jul 26, 2022
@jonhoo
Copy link
Owner

jonhoo commented Jul 26, 2022

Released in 0.11.7 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding strokes to the rectangles representing a stack frame
2 participants