Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4712: Add test case to assert request processors got shutdown in ZooKeeperServer::shutdown #1

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@

import java.io.Flushable;
import java.io.IOException;
import java.net.Socket;

import org.apache.zookeeper.ZooDefs.OpCode;
import org.apache.zookeeper.server.Request;
import org.apache.zookeeper.server.RequestProcessor;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.zookeeper.server;

import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
import java.io.File;
import java.io.IOException;
import org.apache.zookeeper.ZKTestCase;
import org.apache.zookeeper.server.persistence.FileTxnSnapLog;
import org.apache.zookeeper.server.quorum.Learner;
import org.apache.zookeeper.server.quorum.LearnerZooKeeperServer;
import org.apache.zookeeper.server.quorum.QuorumPeer;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

public class ZooKeeperServerShutdownTest extends ZKTestCase {

static class ShutdownTrackRequestProcessor implements RequestProcessor {
boolean shutdown = false;

@Override
public void processRequest(Request request) throws RequestProcessorException {
}

@Override
public void shutdown() {
shutdown = true;
}
}

public static class ShutdownTrackLearnerZooKeeperServer extends LearnerZooKeeperServer {
public ShutdownTrackLearnerZooKeeperServer(FileTxnSnapLog logFactory, QuorumPeer self) throws IOException {
super(logFactory, 2000, 2000, 2000, -1, new ZKDatabase(logFactory), self);
}

@Override
protected void setupRequestProcessors() {
firstProcessor = new ShutdownTrackRequestProcessor();
syncProcessor = new SyncRequestProcessor(this, null);
syncProcessor.start();
}

ShutdownTrackRequestProcessor getFirstProcessor() {
return (ShutdownTrackRequestProcessor) firstProcessor;
}

SyncRequestProcessor getSyncRequestProcessor() {
return syncProcessor;
}

@Override
public Learner getLearner() {
return null;
}
}

@Test
void testLearnerZooKeeperServerShutdown(@TempDir File tmpDir) throws Exception {
File tmpFile = File.createTempFile("test", ".dir", tmpDir);
tmpFile.delete();
FileTxnSnapLog logFactory = new FileTxnSnapLog(tmpFile, tmpFile);
ShutdownTrackLearnerZooKeeperServer zooKeeperServer = new ShutdownTrackLearnerZooKeeperServer(logFactory, new QuorumPeer());
zooKeeperServer.startup();
zooKeeperServer.shutdown(false);
assertTrue(zooKeeperServer.getFirstProcessor().shutdown);
assertFalse(zooKeeperServer.getSyncRequestProcessor().isAlive());
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails before apache#2154.

}
}