forked from apache/zookeeper
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZOOKEEPER-4712: Add test case to assert request processors got shutdown in ZooKeeperServer::shutdown #1
Merged
jonmv
merged 1 commit into
jonmv:jonmv/ZOOKEEPER-4541-take-2
from
kezhuw:ZOOKEEPER-4712-test-case
Sep 20, 2024
Merged
ZOOKEEPER-4712: Add test case to assert request processors got shutdown in ZooKeeperServer::shutdown #1
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
zookeeper-server/src/test/java/org/apache/zookeeper/server/ZooKeeperServerShutdownTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.zookeeper.server; | ||
|
||
import static org.junit.jupiter.api.Assertions.assertFalse; | ||
import static org.junit.jupiter.api.Assertions.assertTrue; | ||
import java.io.File; | ||
import java.io.IOException; | ||
import org.apache.zookeeper.ZKTestCase; | ||
import org.apache.zookeeper.server.persistence.FileTxnSnapLog; | ||
import org.apache.zookeeper.server.quorum.Learner; | ||
import org.apache.zookeeper.server.quorum.LearnerZooKeeperServer; | ||
import org.apache.zookeeper.server.quorum.QuorumPeer; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.io.TempDir; | ||
|
||
public class ZooKeeperServerShutdownTest extends ZKTestCase { | ||
|
||
static class ShutdownTrackRequestProcessor implements RequestProcessor { | ||
boolean shutdown = false; | ||
|
||
@Override | ||
public void processRequest(Request request) throws RequestProcessorException { | ||
} | ||
|
||
@Override | ||
public void shutdown() { | ||
shutdown = true; | ||
} | ||
} | ||
|
||
public static class ShutdownTrackLearnerZooKeeperServer extends LearnerZooKeeperServer { | ||
public ShutdownTrackLearnerZooKeeperServer(FileTxnSnapLog logFactory, QuorumPeer self) throws IOException { | ||
super(logFactory, 2000, 2000, 2000, -1, new ZKDatabase(logFactory), self); | ||
} | ||
|
||
@Override | ||
protected void setupRequestProcessors() { | ||
firstProcessor = new ShutdownTrackRequestProcessor(); | ||
syncProcessor = new SyncRequestProcessor(this, null); | ||
syncProcessor.start(); | ||
} | ||
|
||
ShutdownTrackRequestProcessor getFirstProcessor() { | ||
return (ShutdownTrackRequestProcessor) firstProcessor; | ||
} | ||
|
||
SyncRequestProcessor getSyncRequestProcessor() { | ||
return syncProcessor; | ||
} | ||
|
||
@Override | ||
public Learner getLearner() { | ||
return null; | ||
} | ||
} | ||
|
||
@Test | ||
void testLearnerZooKeeperServerShutdown(@TempDir File tmpDir) throws Exception { | ||
File tmpFile = File.createTempFile("test", ".dir", tmpDir); | ||
tmpFile.delete(); | ||
FileTxnSnapLog logFactory = new FileTxnSnapLog(tmpFile, tmpFile); | ||
ShutdownTrackLearnerZooKeeperServer zooKeeperServer = new ShutdownTrackLearnerZooKeeperServer(logFactory, new QuorumPeer()); | ||
zooKeeperServer.startup(); | ||
zooKeeperServer.shutdown(false); | ||
assertTrue(zooKeeperServer.getFirstProcessor().shutdown); | ||
assertFalse(zooKeeperServer.getSyncRequestProcessor().isAlive()); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails before apache#2154.