Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logLevel typo in README.md #28

Closed
kozmanbalint opened this issue May 31, 2016 · 1 comment
Closed

logLevel typo in README.md #28

kozmanbalint opened this issue May 31, 2016 · 1 comment

Comments

@kozmanbalint
Copy link

README suggests this:

Logger.useDefaults({
    logLevel: Logger.WARN,
    formatter: function (messages, context) {
        messages.unshift('[MyApp]');
        if (context.name) messages.unshift('[' + context.name + ']');
    }
})

However logLevel property should be defaultLevel according to the code.
jonnyreeves added a commit that referenced this issue Jul 5, 2016
@jonnyreeves
Add Logger.createDefaultHandler()
3083fd3 
Provide a way to access the default handler which writes to the appropriate console method (including shims for legacy browsers).  This makes it easy to extend the default handler with your own custom logic.

Fixes #26, #28
@jonnyreeves
Copy link
Owner

Thanks for reporting, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonnyreeves @kozmanbalint