Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added debug handler #34

Merged
merged 2 commits into from
Aug 22, 2016
Merged

Added debug handler #34

merged 2 commits into from
Aug 22, 2016

Conversation

ajwagner777
Copy link
Contributor

Debug handler was missing. Added it in so that debug messages get logged to console correctly.

Debug handler was missing.  Added it in so that debug messages get
logged to console correctly.
@ajwagner777
Copy link
Contributor Author

I see now that the tests failed. Would you be opposed to changing the assertion like so: assert.ok(console.debug.calledOnce, "logger.debug calls console.debug");

@jonnyreeves
Copy link
Owner

Thanks for the pull @ajwagner777, your change to the tests sounds like a good one.

Committing so I can test on another machne.
@ajwagner777
Copy link
Contributor Author

Is there any specific way to get the tests to run? On mac and windows, I get an error:

[09:57:10] Starting 'test'...
[09:57:11] Testing index.html
[09:57:11] Can't open '/Users/aaronwagner/Development/js-logger/node_modules/gulp-qunit/node_modules/qunit-phantomjs-runner/runner-json.js'

[09:57:11] 'test' errored after 1.01 s
[09:57:11] Error in plugin 'gulp-qunit'

@jonnyreeves
Copy link
Owner

jonnyreeves commented Aug 22, 2016

@ajwagner777 hmm, so they should just work on a fresh checkout when you:

git clone ...
npm i 
npm test

This PR's build is green, so let's land this now - feel free to cut a bug if you can't get the tests to work locally on a fresh checkout.

@jonnyreeves jonnyreeves merged commit 94662db into jonnyreeves:master Aug 22, 2016
@jonnyreeves jonnyreeves mentioned this pull request Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants