Collection made generic & type to Group.children #655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group.children
if I am not mistaken is the collection of items added by theGroup.Add
method. So they areTwoElements
.With this assumption I made
Collection
generic. (with default of any in order to prevent affecting other usages)And also defined
Children
type as a collection ofTwoElements
. And alsoGroup.children
asChildren
.this made usages possible like,
this.root.children.forEach(child => this.root.position.blablabla
I am still thinking of
export class Children extends Collection<Shape> ...
but children is filled by Add and it accepts TwoElement; so I think i will stick with that.