Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy remove gridlines #45

Conversation

thomas-neitmann
Copy link
Contributor

Easily remove grid lines, as discussed in #31.

@jonocarroll
Copy link
Owner

Thank you! I'll work through the changes soon. I like the idea of abstracting out the teach argument but I want to carefully check some edge-cases.

@jonocarroll
Copy link
Owner

Sorry, I got distracted from this but I'm having a closer look now. I have some suggestions I'm going to try to push to your branch.

Also, FYI,

Warning message:
`ctxt_frame()` is deprecated as of rlang 0.3.0.

@thomas-neitmann
Copy link
Contributor Author

Thanks a lot for merging into master @jonocarroll!

In the meantime I thought of a slightly different interface for the functions. What do you think of

easy_remove_gridlines <- function(which = "XYxy")
easy_remove_x_gridlines <- function(which = "Xx")
easy_remove_y_gridlines <- function(which = "Yy")

Upper and lowercase letters would indicate major and minor gridlines, respectively. I've implement it like this for the themes in {ggcharts} here.

I feel this is a much cleaner and easier to use interface. What do you think?

@jonocarroll jonocarroll changed the base branch from master to cranfixes_mar2023 March 11, 2023 02:06
@jonocarroll jonocarroll merged commit 109c4d1 into jonocarroll:cranfixes_mar2023 Mar 11, 2023
@jonocarroll
Copy link
Owner

I've been meaning to merge this for far too long. Thank you again for the contribution!

@jonocarroll jonocarroll mentioned this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants