Fix build and update node versions to test with #333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully makes node 4 build pass.
This was referenced May 14, 2019
|
Legend @dominykas 👍 |
|
Can this be merged and the security fix as well? all repos using remarkable now have a big security GitHub warning. |
|
Build is fixed. Node versions upgraded. Thanks for heads up. |
|
Do you want me to rebase my other PRs? |
|
Sure would be great! |
|
Done. Thanks for bringing this back to life! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will be looking into fixing #332 next, but I'd like to see a green build as a starting point.
I wasn't sure about the distinction between
masteranddev, so I started onmaster. I found the last green build and it was using an pinnedeslintversion - it seems the same version is also pinned ondev- I believe #323 has an attempt to upgradeeslintto something more modern, but my top priority here is getting rid of the XSS, so maybe some other day :)I also restored some other deps, that were present in the last green build I could find (https://github.com/jonschlinkert/remarkable/tree/429881961da02f351393050a698c447376df5328).