Removed example for health check endpoint because it is misleading #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please elaborate a bit. Do you mean port 53? |
|
You're right it's port 53. I had to install acme-dns outside of my Kubernetes cluster due to this, so it might be missleading to show that as an example. |
|
I see, that sounds reasonable, LGTM |
joohoi
approved these changes
Oct 21, 2019
jacobmyers-codeninja
pushed a commit
to jacobmyers-codeninja/acme-dns
that referenced
this pull request
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to confusion. Kubernetes is a very bad example to show off the health check endpoint because Kubernetes service discovery blocks port 51.