Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install ca-certificates package #39

Merged
merged 2 commits into from
Feb 1, 2018

Conversation

leonkyneur
Copy link
Contributor

package ca-certificates is not installed by default on alpine.. this fixes the following error when using autocert.
01/02/2018 9:02:53 pmINFO[0020] http: TLS handshake error from X.X.X.X:48846: Get https://acme-v01.api.letsencrypt.org/directory: x509: failed to load system roots and no roots provided

@coveralls
Copy link

coveralls commented Feb 1, 2018

Coverage Status

Coverage remained the same at 92.373% when pulling d039df1 on leonkyneur:update-cacertificates into 476f6fc on joohoi:master.

@joohoi
Copy link
Owner

joohoi commented Feb 1, 2018

Awesome! Thanks for the PR. autocert functionality was obviously something I didn't test on the Docker images. Nice to have it fixed!

@joohoi joohoi merged commit 9f89675 into joohoi:master Feb 1, 2018
@leonkyneur leonkyneur deleted the update-cacertificates branch February 8, 2018 15:18
jacobmyers-codeninja pushed a commit to jacobmyers-codeninja/acme-dns that referenced this pull request Sep 30, 2020
gbonnefille added a commit to gbonnefille/acme-dns that referenced this pull request Apr 29, 2022
Needed to ensure everything runs fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants