Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WTF is "patch chain" #234

Closed
mbabker opened this issue Oct 18, 2019 · 0 comments
Closed

WTF is "patch chain" #234

mbabker opened this issue Oct 18, 2019 · 0 comments

Comments

@mbabker
Copy link

mbabker commented Oct 18, 2019

Trying to apply a chain of patches is asking for trouble. Perhaps you should review the prior implementation which had mechanisms in place to keep people from applying multiple patches affecting a single file, because that's really the only reason you would need a "chain". And unless your magical Drone server is merging multiple pull requests together, anything in the "chain" cannot be tested correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant