Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript Changes For The Sake Of Change #236

Closed
mbabker opened this issue Oct 18, 2019 · 1 comment
Closed

JavaScript Changes For The Sake Of Change #236

mbabker opened this issue Oct 18, 2019 · 1 comment

Comments

@mbabker
Copy link

mbabker commented Oct 18, 2019

The patchtester.js file was changed for the sake of changing it, I can't deduce any other valid explanation for why it was changed. It also removed a very explicit warning message when using the reset function.

This is why there should be a reason for change and not just "oh this is the flavor of the day well cool beans". Not to mention code reviews, because anyone would've seen that removal if they had looked for more than half a second.

@roland-d
Copy link
Collaborator

Good call. I have restored the warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants