Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sha384 signature to manifest.xml #204

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

alikon
Copy link

@alikon alikon commented Mar 14, 2018

with the merge of joomla/joomla-cms#17619. in the 3.9 branch

Summary of Changes

added the <sha384></sha384> tag to the manifest file

Testing Instructions

on joomla < 3.9 nothing change
on joomla 3.9 the checksum is checked

@zero-24
Copy link

zero-24 commented Mar 14, 2018

Why not use sha512? Or is there a special reason to use sha384?

@alikon
Copy link
Author

alikon commented Mar 14, 2018

no special reason except than composer use sha384 iirc.... and this one https://stackoverflow.com/questions/10061532/why-chose-sha512-over-sha384

@mbabker mbabker merged commit 677cdf9 into joomla-extensions:master Mar 19, 2018
@alikon alikon deleted the patch-3 branch March 20, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants