Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix applying patches failing on Linux hosts #242

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

richard67
Copy link

Pull Request for Issue #240 .

Summary of Changes

Use DIRECTORY_SEPARATOR for expode and implode of the path to files to be backed up so that later creating the directories for the backups doesn't fail.

I don't know if this is the right way to fix it, but it works here.

Testing Instructions

See issue #240 .

@richard67
Copy link
Author

richard67 commented Oct 20, 2019

@Hackwar If you don't like DIRECTORY_SEPARATOR we might have to use '/'? If so, let me know here and I'll change this PR.

P.S.: Unfortunately I don't have a Windows test system. Someone should test if '/' or DIRECTORY_SEPARATOR works on Windows, too.

@richard67
Copy link
Author

Sorry, my previous post was in German first by accident. Have changed it to Englisdh yesterday. Unfortunately still no reaction. So the Patchtester 4 with CI enabled is not usable on Linux or other Unixoids. What a pity.

@Hackwar Hackwar merged commit a2b354a into joomla-extensions:4.0-dev Oct 24, 2019
@richard67 richard67 deleted the patch-2 branch November 27, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants