-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Joomla Dialog, implementation for Media, User Fields #40152
Conversation
Looks good, I still need to test. |
build/media_source/system/js/fields/joomla-field-media.w-c.es6.js
Outdated
Show resolved
Hide resolved
I renamed them. I think it would be a good idea to have a
I disagree here. The script should provide some basic styling (mind I didn't copy everything from your PR, only the CE parts) and also the template has the ability to override the assets. Also we're doing that with the alerts and tabs..
Removed them |
That is true, originaly I also wanted to do a separated css, but then I realise that the basic styling already comes with native |
Pull Request for Issue # .
Summary of Changes
Testing Instructions
npm ci
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
User Field
Media Field
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed