Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Animation for new dialog #41748

Merged
merged 4 commits into from
Sep 16, 2023
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Sep 14, 2023

Pull Request for Issue # .

Summary of Changes

A litle animation for dialog, very similar to bs modal

Testing Instructions

Apply patch, run npm install
Go to menu, edit menu Single Article, and select Artcile

Actual result BEFORE applying this Pull Request

Dialog without animation

Expected result AFTER applying this Pull Request

Dialog with animation

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

References:

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Sep 14, 2023
@Fedik Fedik added the Feature label Sep 14, 2023
@ChristineWk
Copy link

I have tested this item ✅ successfully on a827687


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41748.

@wilsonge
Copy link
Contributor

@Fedik
Copy link
Member Author

Fedik commented Sep 14, 2023

Added

@Quy
Copy link
Contributor

Quy commented Sep 14, 2023

I have tested this item ✅ successfully on 0d44b06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41748.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 0d44b06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41748.

@richard67 richard67 changed the title [5.0] Animation for new dialog [5.0] Animation for new dialog Sep 14, 2023
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41748.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit labels Sep 14, 2023
@HLeithner HLeithner merged commit 283452b into joomla:5.0-dev Sep 16, 2023
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 16, 2023
@Fedik Fedik deleted the dialog-animation branch September 16, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants