[4.4] [Guided Tours] The categories tour is not visible to Managers #44116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m the extension associated with those categories.
brianteeman
reviewed
Sep 19, 2024
administrator/modules/mod_guidedtours/src/Helper/GuidedToursHelper.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Teeman <brian@teeman.net>
|
I have tested this item ✅ successfully on 86706a8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44116. |
|
I have tested this item ✅ successfully on 86706a8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44116. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44116. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44089.
Summary of Changes
When the tour is a category, the authorization to run should come from the extension associated with those categories.
Testing Instructions
Create a user with Manager privileges.
Login as that user.
Actual result BEFORE applying this Pull Request
The tour 'How to create a category' does not show in the list of tours (in the modal).
Expected result AFTER applying this Pull Request
The tour 'How to create a category' shows in the list of tours (in the modal).
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed