Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to vanilla cookie consent 3.0.0 #16

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

ArturBa
Copy link
Contributor

@ArturBa ArturBa commented Nov 13, 2023

this should be verified

src/main.ts Outdated Show resolved Hide resolved
Co-authored-by: Michał Kuczaj <37776903+mikucz@users.noreply.github.com>
@cngJo
Copy link
Member

cngJo commented Jan 29, 2024

Hi @ArturBa,

sorry it took me so long. Will take a look and get to testing the next days, since v3 is now officially out.

On first sight the changes look good but I want to test the changes in src/main.ts in a test installation of mine to verify them.

Thanks a lot in advance and for your patience!

Copy link
Member

@cngJo cngJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the version back to 2.0.0, will raise it when I do the final release of 3.0.0.

Also fixed the export type in src/main.ts.

Tested it on my own website and was able to use it without any issues, thanks for your work in this 🎉

@cngJo cngJo merged commit 94a0525 into jop-software:main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants