Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(conf): add braces around property access #44

Merged
merged 1 commit into from
Feb 18, 2022
Merged

bugfix(conf): add braces around property access #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Classes/Domain/Configuration/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function __construct(

foreach ($configuration as $key => $value) {
if (property_exists(__CLASS__, $key) && $value !== "") {
$this->$key = $value;
$this->{$key} = $value;
}
}
} catch (Exception $exception) {
Expand All @@ -64,7 +64,11 @@ private function populateWithEnvironmentVariables(): void
foreach ($envMapping as $conf) {
$value = getenv($conf[1]);
if ($value) {
$this->$conf[0] = $value;
$type = gettype($this->{$conf[0]});
settype($value, $type);
// FIXME: Remove comment when phpstan has proper support for \settype();
// @phpstan-ignore-next-line
$this->{$conf[0]} = $value;
}
}
}
Expand Down