Handle module __builtins__ both as dict or module #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jopohl
requested changes
Mar 13, 2024
Co-authored-by: Dr. Johannes Pohl <Johannes.Pohl90@gmail.com>
jopohl
reviewed
Mar 14, 2024
Co-authored-by: Dr. Johannes Pohl <Johannes.Pohl90@gmail.com>
|
I see macOS keeps failing now and was not failing in other workflow runs, but I'm unable to find relation with this patch. Should we worry about it? |
|
Good catch. I just merged a fix for the macOS tests to master. Can you please merge it to your branch to ensure the CI is green afterwards? |
|
Hmm I used GitHub sync fork button and a "merge" commit was added. Want me to squash commits to keep git history clean? Alternatively, if you want it is possible to squash and merge once it is all good. |
|
All good, I'll just squash all your commits into one for clean history in URH. Thanks for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1106