Signal: retain the sample_rate on create_new #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
When using "Create signal from selection" feature, the newly created signal does not retain sample rate of the original so all the time of the selection is computed wrong which is very confusing to the user. This simple patch makes sure the sample_rate of the original Signal is copied to the newly created one which fixes the problem.
kadamski
force-pushed
the
signal_create_new_fix
branch
from
d3607f0
to
5050349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using "Create signal from selection" feature, the newly created
signal does not retain sample rate of the original so all the time of
the selection is computed wrong which is very confusing to the user.
This simple patch makes sure the sample_rate of the original Signal is
copied to the newly created one which fixes the problem.